Use type-only import for axios types #541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the axios imports
The original code was importing both functions and types together from the axios library.
To make the code more readable and follow best practices, I've separated the import statements into two lines.
The first line now imports only the type definitions, i.e., AxiosInstance, AxiosRequestConfig, HeadersDefaults, and ResponseType from axios.
The second line imports the axios library itself.
Note:
I've observed that in Vue projects built with Vite, the current approach does not only cause issues with the linter but also leads to build failures. The build process does not produce runnable code if type imports are not separated from library imports. Although the root cause of this behavior in Vite is unclear for me, these changes address this problem and ensure successful builds.