Remove unnecessary camel case conversion for query params #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase to latest main branch? |
nicky1038
force-pushed
the
prevent-camelcase-query-params
branch
2 times, most recently
from
ed4a65a to
61ddfcc
Compare
|
@smorimoto Hi! Rebase done. Thank you so much for taking over maintenance of this project! |
|
Is anything keeping this from being released? @smorimoto |
|
Hello, this is a blocker for us to upgrade to v13 version. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 4 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- tests/spec/dot-path-params/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/sortTypes-false/snapshots/basic.test.ts.snap: Language not supported
- tests/spec/sortTypes/snapshots/basic.test.ts.snap: Language not supported
|
this is blocker for me too |
|
Still no response? |
|
I got the same issue ... please merge the PR |
smorimoto
force-pushed
the
prevent-camelcase-query-params
branch
from
61ddfcc to
887d139
Compare
🦋 Changeset detectedLatest commit: 0a71f2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smorimoto
changed the title
smorimoto
force-pushed
the
prevent-camelcase-query-params
branch
from
887d139 to
0a71f2b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change introduced in the 13.0.0 major release. Since that release all query parameter names are being renamed into
camelCase. It is a way wrong behavior.Why is it wrong? Say, a backend server expects a query parameter called
a.b. In the Swagger schema provided by that server, that query parameter is also calleda.b. Whenswagger-typescript-apigenerates types, it renames the query parameter toaBbut does not provide any runtime transform. When user passesaBquery parameter, the server obviously cannot recognize it, as it expectsa.b.I cannot understand what task is being solved with that change. Renaming query parameters is not valid at all and breaks logic.
It was suggested in #460. After it was released, numerous users also compained that their clients are generated wrongly.
My PR reverts that change.