fix: format option of requests when using extractResponseBody#742
Merged
Conversation
Collaborator
|
Could you rebase to latest main branch? |
Contributor
Author
|
Hi @smorimoto , I rebase the code to latest main branch. |
Contributor
Author
|
(rebase to latest main branch) |
smorimoto
enabled auto-merge
July 28, 2024 13:53
smorimoto
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
--extract-response-bodyoption, the format option of requests disappears.For example (from
tests/spec/extractResponseBody.js):When running with extractResponseBody: true, the generated code looks like this:
However, when running without
extractResponseBody: true, the generated code includes the format option:I attempted to copy
contentKindto make the format is in the generated request options. I'm not sure if this is the good approach.