Skip to content

use import pattern that supports windows external drives - #930

Merged
smorimoto merged 2 commits into
acacode:mainfrom
thechucklingatom:main
Oct 29, 2024
Merged

use import pattern that supports windows external drives#930
smorimoto merged 2 commits into
acacode:mainfrom
thechucklingatom:main

Conversation

@thechucklingatom

Copy link
Copy Markdown
Contributor

Closes #901

@VeXell VeXell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works on windows

@VeXell

VeXell commented Oct 27, 2024

Copy link
Copy Markdown

@js2me Can you review this small fix please. thx

thechucklingatom and others added 2 commits October 29, 2024 20:35
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto

Copy link
Copy Markdown
Collaborator

@thechucklingatom @VeXell Could you test with the latest commit?

@thechucklingatom

Copy link
Copy Markdown
Contributor Author

Seems to work as expected on my end.

@VeXell

VeXell commented Oct 29, 2024

Copy link
Copy Markdown

@smorimoto Yes. Looks like it works as expected. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESM path failure when importing a template

3 participants