Allow theme switch on client side with a toggle #2889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case of height overflows
|
It looks like you are attempting to push a change to the template repository, for help with deploying your own website please start a new thread in the discussions. |
|
@rjzupkoii This PR is related to issue #911, not for help with my own website. The main feature implementation is to allow dark/light theme toggle on user browser. |
|
@SijieFu PRs that address issues in the backlog are always welcome but we need a bit of documentation as to what we are looking at otherwise the tend to be auto closed since a lot of inadvertent pushes have minimal information in them. Can you create a new PR with a summary of what the code is doing? |
|
@rjzupkoii Thanks for the tip. I opened a new PR #2900. Let me know if you need more information. |
RuiyangSi
pushed a commit
to RuiyangSi/ruiyangsi.github.io
that referenced
this pull request
Apr 25, 2025
Fix site.data.socials.scholar_userid access for google scholar citation count Fixes academicpages#2889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#911