Skip to content

feat(markdown-transform): add table transforms #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

TC5022
Copy link
Collaborator

@TC5022 TC5022 commented Jul 26, 2022

Signed-off-by: TC5022 [email protected]

Changes

  • This is a WIP PR to add table extension in various packages of markdown-transform
  • Currently the changes reflect transformations in common mark DOM, HTML, the slate DOM and PDF

Flags

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 86.03% when pulling 51c4ebd on TC5022:TC5022/table-transformations into ac06acd on accordproject:master.

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Would like to get @dselman 's review too before merging 👍

@TC5022
Copy link
Collaborator Author

TC5022 commented Aug 29, 2022

Thanks @DianaLease!

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Well done!

@dselman dselman merged commit 99d1dd6 into accordproject:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants