Skip to content

fix(learning page): for mobile devices fix sidebar and learning page layout (#331) #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sahilkhan117
Copy link
Contributor

@sahilkhan117 sahilkhan117 commented Mar 26, 2025

Closes #331

Layout(Learning Page): Remove Sidebar for Better Usability on Mobile Screens

Changes

  • Removed the sidebar on smaller screens to enhance readability and usability.
  • Applied full-width content layout for better presentation on mobile devices.
  • Improved navigation visibility by ensuring Previous and Next buttons are always accessible.
  • Added proper padding and spacing for a clean, readable appearance.

Screenshots

Before After
Screenshot 2025-03-26 162456 Screenshot 2025-03-26 162400

Test Devices

  • Samsung Galaxy Z Fold 5
  • Samsung Galaxy S20 Ultra
  • Google Pixel 6 Pro
  • iPhone 13 Pro Max
  • OnePlus 9 Pro
  • Xiaomi Mi 11 Ultra

Flags

  • This solution removes the sidebar only on mobile screens while keeping it on larger screens.
  • The changes were tested on multiple devices to ensure consistent appearance.

🔗 Related Issues

Code Added

for sidebar

@media (max-width: 767px) {
    display: none;
}

for main learning block

@media (max-width: 767px) {
    margin-top: 25px;
    margin-bottom: 30px;
    h1 {
      margin-top: 0;
}

Author Checklist

  • DCO sign-off included
  • Verified on multiple devices
  • Ready for merging into main from fork:sahilkhan117/i331/fix-learn-page-layout

@DianaLease can you please review my PR and Let me know if there is any changes or corrections regarding this problem.

@sahilkhan117 sahilkhan117 requested a review from a team as a code owner March 26, 2025 14:17
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 4613997
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67e40c936fd9aa00082f350f
😎 Deploy Preview https://deploy-preview-332--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sahilkhan117 sahilkhan117 changed the title fix(learning page): for mobile devices fix sidebar and learning page layout fix(learning page): for mobile devices fix sidebar and learning page layout (#331) Mar 26, 2025
@shivasankaran18
Copy link

@sahilkhan117 no sidebar for mobile devices ? .. I too thought of this issue . For better User experience, why can't we have a Hamburger side bar menu .. @DianaLease would like to have your thoughts on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout(Learning Page): The sidebar disturbs the page and make it Unusable
2 participants