Skip to content

Manpad - Add stinger locking #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Manpad - Add stinger locking #10830

wants to merge 9 commits into from

Conversation

PabstMirror
Copy link
Contributor

stinger.mp4

@PabstMirror PabstMirror added the kind/feature Release Notes: **ADDED:** label Mar 29, 2025
@PabstMirror PabstMirror mentioned this pull request Mar 29, 2025
Open
TheCandianVendingMachine
TheCandianVendingMachine reviewed Apr 4, 2025
View reviewed changes
TheCandianVendingMachine
TheCandianVendingMachine reviewed Apr 4, 2025
View reviewed changes
addons/missile_manpad/functions/fnc_eachFrame.sqf
private _lockFeedback = 0;
if (isNull _lockCanidate) then {
// find any target within seeker range
private _potentialTargets = _source nearEntities ["Air", _seekerMaxRange];
Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flares won't be locked with this, idk if thats desired. it may make more sense to break out the target logic into its own function and call that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this should more closely just copy the ir_seeker code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should; i'd want to break the logic into it's own function just because its a but unweidly and if it changes in the future it'd be a pain to update twice

rautamiekka
rautamiekka suggested changes Apr 4, 2025
View reviewed changes
@PabstMirror PabstMirror requested a review from Copilot April 4, 2025 17:13
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp: Language not supported
  • addons/missile_manpad/CfgEventHandlers.hpp: Language not supported
  • addons/missile_manpad/CfgSounds.hpp: Language not supported
  • addons/missile_manpad/CfgWeapons.hpp: Language not supported
  • addons/missile_manpad/XEH_PREP.hpp: Language not supported
  • addons/missile_manpad/XEH_postInit.sqf: Language not supported
  • addons/missile_manpad/XEH_preInit.sqf: Language not supported
  • addons/missile_manpad/XEH_preStart.sqf: Language not supported
  • addons/missile_manpad/config.cpp: Language not supported
  • addons/missile_manpad/functions/fnc_eachFrame.sqf: Language not supported
  • addons/missile_manpad/functions/fnc_weaponChanged.sqf: Language not supported
  • addons/missile_manpad/script_component.hpp: Language not supported
  • addons/missileguidance/dev/mock_ammo.hpp: Language not supported

@TheCandianVendingMachine
Copy link
Contributor

Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (13)

* **addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp**: Language not supported

* **addons/missile_manpad/CfgEventHandlers.hpp**: Language not supported

* **addons/missile_manpad/CfgSounds.hpp**: Language not supported

* **addons/missile_manpad/CfgWeapons.hpp**: Language not supported

* **addons/missile_manpad/XEH_PREP.hpp**: Language not supported

* **addons/missile_manpad/XEH_postInit.sqf**: Language not supported

* **addons/missile_manpad/XEH_preInit.sqf**: Language not supported

* **addons/missile_manpad/XEH_preStart.sqf**: Language not supported

* **addons/missile_manpad/config.cpp**: Language not supported

* **addons/missile_manpad/functions/fnc_eachFrame.sqf**: Language not supported

* **addons/missile_manpad/functions/fnc_weaponChanged.sqf**: Language not supported

* **addons/missile_manpad/script_component.hpp**: Language not supported

* **addons/missileguidance/dev/mock_ammo.hpp**: Language not supported

the fuck is the point of the bot if it doesn't support 99% of the files 😭

@PabstMirror
Copy link
Contributor Author

PabstMirror commented Apr 9, 2025 •
edited
Loading

  • prob do explicit config because CWR has a javelin (AA/blowpipe-like) that inherits from cup_stinger

@TheCandianVendingMachine
Copy link
Contributor

note: this can be expanded to Sidewinder soon whenever this goes stable (https://feedback.bistudio.com/T190789)

rautamiekka
rautamiekka suggested changes May 7, 2025
View reviewed changes
@PabstMirror PabstMirror marked this pull request as ready for review May 25, 2025 15:35
@PabstMirror PabstMirror added this to the 3.20.0 milestone Jun 22, 2025
LinkIsGrim
LinkIsGrim reviewed Jun 22, 2025
View reviewed changes
addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp
@@ -20,3 +20,16 @@ class CfgPatches {

#include "\z\ace\addons\missileguidance\script_missileBases.hpp"
#include "CfgAmmo.hpp"

class CfgWeapons { //todo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address?

LinkIsGrim
LinkIsGrim approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, not tested and the the finer points of missileguidance go over my head.

TheCandianVendingMachine
TheCandianVendingMachine requested changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some thought, I think a common method to search for targets would benefit this. As is it works, but there are discrepancies between the actual seeker and this tracker

@PabstMirror PabstMirror modified the milestones: 3.20.0, Ongoing Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rautamiekka rautamiekka rautamiekka requested changes

@TheCandianVendingMachine TheCandianVendingMachine TheCandianVendingMachine requested changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @TheCandianVendingMachine @rautamiekka @LinkIsGrim