fix parsing errors about template literals (fixes #575) #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575.
In src/tokencontext.js#L112-L119,
classandfunctionkeywords push new context intothis.context. However, there is no chance to pop the context fromthis.contextif the keyword was consumed as an identifier such as{class: 1}. This fact breaks the tokenization of template literals.This PR makes popping the context when a
class/functionkeyword is consumed as an identifier.I'm not sure whether this fixing is correct or not. Because this bug is in tokenization process, but this PR modifies parsing process. Please tell me (or feel free to fix it yourself) if the more proper way exists.