Skip to content

Fix image-button accessibility support editorial oversight #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix image-button accessibility support editorial oversight #2106

merged 2 commits into from
Oct 13, 2023

Conversation

WilcoFiers
Copy link
Member

@WilcoFiers WilcoFiers commented Aug 31, 2023 •
edited
Loading

We forgot to remove this text when we added the accessibility support note.

Need for Call for Review: none, editorial

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers merged commit 94f99d6 into develop Oct 13, 2023
@WilcoFiers WilcoFiers deleted the image-button-assumption-fix branch October 13, 2023 14:37
Jym77 pushed a commit that referenced this pull request Oct 26, 2023
@WilcoFiers @Jym77
Fix image-button accessibility support editorial oversight (#2106)
bb06ca3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@Jym77 Jym77 Jym77 approved these changes

@tbostic32 tbostic32 tbostic32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilcoFiers @carlosapaduarte @Jym77 @tbostic32