Skip to content

Download artifacts to dedicated subfolder when no name or id specified - #422

Open
twsl wants to merge 5 commits into
actions:mainfrom
twsl:feat/fix-dl-all-artifacts
Open

twsl wants to merge 5 commits into
actions:mainfrom
twsl:feat/fix-dl-all-artifacts

Conversation

@twsl

@twsl twsl commented Aug 13, 2025

Copy link
Copy Markdown

Fix #419

Copilot AI review requested due to automatic review settings August 13, 2025 11:42
@twsl
twsl requested a review from a team as a code owner August 13, 2025 11:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where single artifacts downloaded by ID were not being placed in dedicated subfolders. The change ensures that when downloading artifacts without specifying a name or pattern, each artifact is downloaded to its own subfolder named after the artifact, maintaining consistency with the behavior for multiple artifacts.

  • Modified the path resolution logic to consider whether artifacts are being downloaded by ID when determining folder structure
  • Added comprehensive test coverage for both single and multiple artifact downloads to verify the new subfolder behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/download-artifact.ts Updated path resolution condition to ensure single artifacts downloaded by ID are placed in dedicated subfolders
tests/download.test.ts Added tests to verify artifacts are downloaded to dedicated subfolders when no name/ID specified

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread __tests__/download.test.ts
Comment thread __tests__/download.test.ts
oxc added a commit to oxc/kolmafia that referenced this pull request Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc added a commit to oxc/kolmafia that referenced this pull request Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc added a commit to oxc/kolmafia that referenced this pull request Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc added a commit to oxc/kolmafia that referenced this pull request Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 13, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 16, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 17, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 18, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 22, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 23, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 24, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 28, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 29, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Apr 30, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request May 1, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request May 2, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request May 3, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request May 30, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request May 31, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 1, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 2, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 3, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 5, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 6, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 6, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 7, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 8, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 8, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 9, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 10, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 11, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 14, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 14, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 15, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 17, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 18, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 20, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 23, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 25, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 26, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 26, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 27, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 28, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot pushed a commit to oxc/kolmafia that referenced this pull request Jun 29, 2026
download-artifact@v7 no longer creates artifact-name subdirectories,
causing release assets to end up in the workspace root instead of
dist/. Adjust the release file globs to match.

See: actions/download-artifact#455
See: actions/download-artifact#426
See: actions/download-artifact#422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Release notes for v5 are misleading, behavior changes in more cases

6 participants