Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where single artifacts downloaded by ID were not being placed in dedicated subfolders. The change ensures that when downloading artifacts without specifying a name or pattern, each artifact is downloaded to its own subfolder named after the artifact, maintaining consistency with the behavior for multiple artifacts.
- Modified the path resolution logic to consider whether artifacts are being downloaded by ID when determining folder structure
- Added comprehensive test coverage for both single and multiple artifact downloads to verify the new subfolder behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/download-artifact.ts | Updated path resolution condition to ensure single artifacts downloaded by ID are placed in dedicated subfolders |
| tests/download.test.ts | Added tests to verify artifacts are downloaded to dedicated subfolders when no name/ID specified |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
malejmaf7
approved these changes
Sep 12, 2025
GrantBirki
approved these changes
Jan 2, 2026
oxc
added a commit
to oxc/kolmafia
that referenced
this pull request
Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc
added a commit
to oxc/kolmafia
that referenced
this pull request
Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc
added a commit
to oxc/kolmafia
that referenced
this pull request
Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oxc
added a commit
to oxc/kolmafia
that referenced
this pull request
Apr 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 13, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 16, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 17, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 18, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 22, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 23, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 24, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 28, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 29, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Apr 30, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
May 1, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
May 2, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
May 3, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
May 30, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
May 31, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 1, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 2, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 3, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 5, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 6, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 6, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 7, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 8, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 8, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 9, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 10, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 11, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 12, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 14, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 14, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 15, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 17, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 18, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 19, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 20, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 23, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 25, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 26, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 26, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 27, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 28, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
to oxc/kolmafia
that referenced
this pull request
Jun 29, 2026
download-artifact@v7 no longer creates artifact-name subdirectories, causing release assets to end up in the workspace root instead of dist/. Adjust the release file globs to match. See: actions/download-artifact#455 See: actions/download-artifact#426 See: actions/download-artifact#422 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #419