Fix keyword delegation in form component#318
Merged
deivid-rodriguez merged 2 commits intomasterfrom Feb 7, 2022
Merged
Conversation
We added `ruby2_keywords` in other `method_missing` delegations, but not here.
javierjulio
approved these changes
Feb 4, 2022
Member
javierjulio
left a comment
There was a problem hiding this comment.
Totally missed that when reviewing the file beforehand. Thanks a lot! 🙌🏻 Do you see a need to create a test for this or release as is and then just drop Ruby 2.6 support? My understanding is that ruby2_keywords is needed for Ruby 2.6 and below but I could be mistaken.
Member
Author
|
I think we can ship this as is and trust the test you added on the activeadmin side to verify it works as expected. My understanding is that def method_missing(method, *args, **kwargs, &block)
if form_builder && form_builder.respond_to?(method)
proxy_call_to_form(method, *args, **kwargs, &block)
else
super
end
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #312.