Skip to content

Update dependencies and improve CI workflow #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

tagliala
Copy link
Contributor

  • Use strings instead of floats for uniformity
  • Rename "deps" with "rails" for uniformity with Inherited Resources and Active Admin gems
  • Update bundler
  • Fix platforms

Backported from 7.2

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (41ebc98) to head (37e5bb9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          17       17           
  Lines         458      458           
=======================================
  Hits          432      432           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala force-pushed the chore/internal-refactor branch from dacbfa7 to 17697ad Compare June 15, 2024 10:18
- Use strings instead of floats for uniformity
- Rename "deps" with "rails" for uniformity with Inherited Resources and
  Active Admin gems
- Update bundler
- Fix platforms
- Fix RuboCop configuration to allow `rubocop-rspec` 3.0
@tagliala tagliala force-pushed the chore/internal-refactor branch from 17697ad to 37e5bb9 Compare June 15, 2024 10:20
@tagliala tagliala mentioned this pull request Jun 15, 2024
1 task
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 7eeccf7 into activeadmin:master Jun 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants