Stripe: Add support for statement_descriptor_suffix field#3528
Merged
Carrigan merged 1 commit intoFeb 17, 2020
Merged
Conversation
fatcatt316
approved these changes
Feb 17, 2020
fatcatt316
left a comment
fatcatt316
left a comment
Contributor
There was a problem hiding this comment.
Left a couple comments, but this all looks bueno to me. Nice work!
Contributor
There was a problem hiding this comment.
I like this way of setting a variable instead of using two different strings down below (one when setting, and one when asserting). 👍
Contributor
There was a problem hiding this comment.
Ah, this must be the pattern that this code was trying to follow. Good to know!
Contributor
Author
|
Thanks for the review @fatcatt316 |
CE-419 Adds support for the `statement_descriptor_suffix` field on both the Stripe and the Stripe Payment Intents gateways.
Carrigan
force-pushed
the
CE-419-statement-descriptor-suffix
branch
from
d1ed4db to
3b1fdad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
What Changed?
Adds support for the
statement_descriptor_suffixfield on both the Stripe and the Stripe Payment Intents gateways.Test Suites
Stripe Remote Tests
Stripe Payment Intents Remote Tests
Unit Tests