TNS/TransFirstTransactionExpress/USA EPAY: Normalize the use of API_VERSION #5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-sharmas
force-pushed
the
normalize_tns_transfirst_usaepay_versions
branch
from
8b43023 to
9775927
Compare
sumit-sharmas
force-pushed
the
normalize_tns_transfirst_usaepay_versions
branch
3 times, most recently
from
4c6762f to
5feabcb
Compare
There was a problem hiding this comment.
will let @almalee24 take a look once about pattern we're following and optimzations (if any)
almalee24
reviewed
Jul 11, 2025
lib/active_merchant/billing/gateways/trans_first_transaction_express.rb
Outdated
Show resolved
Hide resolved
sumit-sharmas
force-pushed
the
normalize_tns_transfirst_usaepay_versions
branch
3 times, most recently
from
94a5046 to
fb9fca9
Compare
| @@ -62,7 +62,7 @@ module Billing # :nodoc: | |||
| # * {USA ePay Developer Login}[https://www.usaepay.com/developer/login] | |||
| # | |||
| class UsaEpayAdvancedGateway < Gateway | |||
| API_VERSION = '1.4' | |||
| version '1.4' | |||
There was a problem hiding this comment.
Is this not used anywhere?
There was a problem hiding this comment.
@adarsh-spreedly yes, it is not used anywhere.
Normalize the use of API_VERSION for TNS, TransFirstTransactionExpress and USA EPAY gateways. Remote: TNS: 13 tests, 26 assertions, 9 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 23.0769% passed TransFirstTransactionExpress: 34 tests, 0 assertions, 0 failures, 34 errors, 0 pendings, 0 omissions, 0 notifications 0% passed USA EPAY: USA EPAY advanced: 40 tests, 0 assertions, 0 failures, 40 errors, 0 pendings, 0 omissions, 0 notifications 0% passed USA EPAY transaction: 34 tests, 0 assertions, 0 failures, 34 errors, 0 pendings, 0 omissions, 0 notifications 0% passed
sumit-sharmas
force-pushed
the
normalize_tns_transfirst_usaepay_versions
branch
from
fb9fca9 to
39e4583
Compare
|
@sumit-sharmas - about remote tests - were you not able to find creds for gateways? |
|
@ankurspreedly I was able to find some credentials for the gateways, but they don’t seem to be working—possibly expired or no longer valid. |
ankurspreedly
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the use of API_VERSION for TNS, TransFirstTransactionExpress and USA EPAY gateways.
Remote Test Results:
TNS:
13 tests, 26 assertions, 9 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 23.0769% passed
TransFirstTransactionExpress:
34 tests, 0 assertions, 0 failures, 34 errors, 0 pendings, 0 omissions, 0 notifications 0% passed
USA EPAY:
USA EPAY advanced:
40 tests, 0 assertions, 0 failures, 40 errors, 0 pendings, 0 omissions, 0 notifications 0% passed
USA EPAY transaction:
34 tests, 0 assertions, 0 failures, 34 errors, 0 pendings, 0 omissions, 0 notifications 0% passed