Update Node support to match versions currently supported by AWS #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests/Linting working locally, I'm trying to figure out why its failing on the build. Sorry, I am not overly familiar with GH Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
This PR updates the supported Node version to include v18, v20, and v22 (aligns with current AWS supported Node versions). This PR was influences/inspired by this PR from @activescott.
How did you implement it:
I updated node version definitions in the
package.json,.github/workflows/build.yml,examples/basic/serverless.yml, andexamples/comprehensive/serverless.ymlfiles.How can we verify it:
Test should pass and build should not contain errors.
Todos:
npm run lintlocally)npm run test)