remove _typing and circuitpython_typing #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest making this a major version bump, to 7.0.0. |
This was referenced Feb 16, 2022
makermelissa
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circuitpython_typingis now a pypi library of its own (adafruit-circuitpython-typing), and no longer needs to be part ofadafruit-blinka.Remove the typing source files, and all mentions.
I don't thinking anything using _typing now. I think we can discard that.
I also ran pre-commit experimentally. I didn't pay attention to the
pylintresults, but it did make oneblackchange and added a missing newline at the end of a file.Don't merge this until these two libraries are updated to require
adafruit-circuitpython-typing:debug-i2cadafruit_bus_device