Add decoding support for Record Type 4 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Record type 4, as described here: https://en.wikipedia.org/wiki/Intel_HEX#Record_types
|
@FoamyGuy would you mind reviewing this? |
FoamyGuy
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
The details of the specific record type and it's usage while programming AVR devices is a bit beyond my level of understanding.
However the way that it's been added to this library does look okay to me.
Thanks for digging into this and adding the functionality @mafiltenborg
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 11, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_TM#7 from tekktrik/feature/add-typing > Updated readthedocs file > Updated readthedocs requirements path > Disabled unspecified-encoding pylint check > add docs link to readme > Globally disabled consider-using-f-string pylint check > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.4.0 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#28 from mafiltenborg/patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#27 from mafiltenborg/patch-1 > Updated readthedocs file > Disabled unspecified-encoding pylint check > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#26 from adafruit/patch-fix > PATCH Pylint and readthedocs patch test > add docs link to readme > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.6.0 from 3.5.1: > Updated readthedocs file > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#48 from FoamyGuy/remove_gamepad_usage > Disabled unspecified-encoding pylint check > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#51 from adafruit/patch-fix > PATCH Pylint and readthedocs patch test > add docs link to readme > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Record type 4, as described here:
https://en.wikipedia.org/wiki/Intel_HEX#Record_types
Toolchains differ. I happen to operate one that uses Record type 4 in its generated Hex-files.