Remove from_entry and provide entry in __init__ #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows subclasses to directly manage how they are initialized when created from a ScanEntry.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 2, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.0.0 from 7.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#123 from tannewt/remove_from_entry > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.10.6 from 0.10.5: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#19 from tannewt/remove_move_to_end > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#13 from adafruit/tannewt-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#12 from tannewt/pass_entry > "Increase duplicate code check threshold "
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subclasses to directly manage how they are initialized
when created from a ScanEntry.
I'll follow up with two library repos that need their init to be updated.