Function signature fixes #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Looks good to me. Thank you for the fix @brentyi!
For anyone interested there is more info about typing.Type here: https://docs.python.org/3/library/typing.html#typing.Type that explains the difference in the code changed with this PR.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 13, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.1.10 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#39 from xenomorpheus/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.3.0 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#34 from kriswilk/patch-1 > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.2.11 from 2.2.10: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#23 from edanidzerda/main > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 9.0.2 from 9.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#183 from brentyi/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.26.0 from 2.24.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#184 from Neradoc/fix-multiple-lines-in-bitmaplabel > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#186 from Neradoc/fix-bitmap-label-anchored-position Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_GFX Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
There are a handful of functions in
adafruit_blethat clearly expect advertisement/service types, but where the signature specifies advertisement/service instances.Just fixed the cases I noticed, would be nice for suppressing some errors.