Added pylint ignores so Actions will pass #51
Conversation
There was a problem hiding this comment.
I forgot to clarify that this PR will also need to remove the ignores from the pylint invocation in .travis.yml. Technically it doesn't need them to be removed, but the main point of this PR is to not need the ignores that are being added to the pylint invocation because they won't be there when actions is doing the linting. There's no reason to leave them in .travis.yml once they've been added to the code, and removing them now will make it clear that you've added all of the required new ones.
Please remove the ignores from the travis.yml and then see where the linting is at
| @@ -248,6 +249,7 @@ def _init_devices(self): | |||
| i += size | |||
|
|
|||
| def get_report_info(collection, reports): | |||
| """ Gets info about hid reports """ | |||
There was a problem hiding this comment.
This seems like an accurate if brief description. It can be filled out more if need be.
|
@dherrada have you been able to put any time into this? I'd like to try and get it merged soon edit:whoops! I missed your commits; looking now |
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 4.0.0 from 3.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#53 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_BLE#49 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BLE#51 from adafruit/dherrada-patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_BLE#33 from ntoll/master > Merge pull request adafruit/Adafruit_CircuitPython_BLE#48 from tannewt/remove_magic_light > Merge pull request adafruit/Adafruit_CircuitPython_BLE#47 from tannewt/remove_ancs Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE
There were 2 things I wasn't quite sure about:
line 86 of adafruit_ble/advertising/__init__.py
I added a pass to it because It wouldn't pass pylint completely empty even with an ignore. I don't think this should have an effect on the operation of the module, but I just wanted to check.
Edit: So I'm realizing that adding a pass causes travis to fail, but in testing it locally using the linting command from build.yml, that was the only way it would pass
line 252 of adafruit_ble/services/hid.py
It didn't have a docstring so I added one. Just wanted to see if there was a better way of describing that function than what I put