timeout and state of advertising & keyboard leds info#98
Conversation
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Very nice! Thank you. Just a few changes.
| self._connection_cache = {} | ||
|
|
||
| def start_advertising(self, advertisement, scan_response=None, interval=0.1): | ||
| def start_advertising(self, advertisement, scan_response=None, interval=0.1, timeout=0): |
There was a problem hiding this comment.
Use timeout=None to indicate no timeout. That is more Pythonic, and the way we do it in other similar API's. For instance, BLERadio.start_scan() uses timeout=None.
| `BLERadio.name` and `BLERadio.tx_power`. | ||
| :param float interval: advertising interval, in seconds | ||
| :param int timeout: advertising timeout in seconds. | ||
| If 0, no timeout. |
|
Run the "black" formatter over the changed source files, to fix the build failure. |
|
Thanks for the review. Updated |
|
BTW, you can allow us to make simple edits to this or future PR's if you check a box. See: |
|
Thanks. Will do that next time. |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Great, thank you for putting in these missing pieces!
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.2.0 from 7.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#98 from makerdiary/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.6 from 0.11.5: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#37 from adafruit/default-params Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#5 from makermelissa/master
2 participants
timeouttoBLERadio.start_advertisingBLERadio.advertisingpropertyReportOut.reportproperty to get keyboard leds info