Skip to content

Broadcast fails in CircuitPython because move_to_end() is not implemented #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aww opened this issue Jan 25, 2021 · 1 comment · Fixed by #19
Closed

Broadcast fails in CircuitPython because move_to_end() is not implemented #18

aww opened this issue Jan 25, 2021 · 1 comment · Fixed by #19

Comments

@aww
Copy link

aww commented Jan 25, 2021

OrderedDict.move_to_end() is used during .broadcast() but this method of OrderedDIct is not implemented in CircuitPython.

code.py output:
This is BroadcastNet Feather Sense sensor: e1ea5705e4b6
Traceback (most recent call last):
  File "code.py", line 30, in <module>
  File "adafruit_ble_broadcastnet.py", line 54, in broadcast
  File "adafruit_ble/__init__.py", line 183, in start_advertising
  File "adafruit_ble_broadcastnet.py", line 188, in __bytes__
AttributeError: 'OrderedDict' object has no attribute 'move_to_end'

Code done running.

Adafruit CircuitPython 6.1.0 on 2021-01-21; Adafruit Feather Bluefruit Sense with nRF52840```
@tannewt tannewt mentioned this issue Jan 26, 2021
Merged
@tannewt
Copy link
Member

tannewt commented Jan 26, 2021

(see discussion in #16 about fixing this)

@tannewt tannewt mentioned this issue Mar 15, 2021
Closed
tannewt added a commit to tannewt/Adafruit_CircuitPython_BLE_BroadcastNet that referenced this issue Mar 22, 2021
@tannewt
Get rid of move_to_end
3bfef11 
Instead, just set a placeholder sequence_number

Fixes adafruit#18
@tannewt tannewt mentioned this issue Mar 22, 2021
Merged
@ladyada ladyada mentioned this issue Mar 26, 2021
Closed
tannewt added a commit to tannewt/Adafruit_CircuitPython_BLE_BroadcastNet that referenced this issue Apr 1, 2021
@tannewt
Get rid of move_to_end
bb55e32 
Instead, just set a placeholder sequence_number when not created
from a ScanEntry.

Fixes adafruit#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get rid of move_to_end tannewt/Adafruit_CircuitPython_BLE_BroadcastNet
2 participants
@tannewt @aww