We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A typo in the code makes the gas sampling take over 4 seconds in most cases.
As per datasheet, _calc_gas_wait(100) should be 0x59 but we always get 0xff instead -- I suggest adding a test with this known-good value.
_calc_gas_wait(100)
0x59
0xff
The code currently reads
durval: UINT8 = 0xFF # Max duration if dur < 0xFC0: return durval
but it should be
durval: UINT8 = 0xFF # Max duration if dur >= 0xFC0: return durval
cf https://github.com/boschsensortec/BME68x-Sensor-API/blob/master/bme68x.c#L1181C13-L1181C13
That's probably the root cause of #65 and does not help #66 either (because we block waiting for sleep while gas wait is active).
The text was updated successfully, but these errors were encountered:
d744cd4
Merge pull request #68 from CTho9305/main
41fca05
Fix #67
No branches or pull requests
A typo in the code makes the gas sampling take over 4 seconds in most cases.
As per datasheet,
_calc_gas_wait(100)
should be0x59
but we always get0xff
instead -- I suggest adding a test with this known-good value.The code currently reads
but it should be
cf https://github.com/boschsensortec/BME68x-Sensor-API/blob/master/bme68x.c#L1181C13-L1181C13
That's probably the root cause of #65 and does not help #66 either (because we block waiting for sleep while gas wait is active).
The text was updated successfully, but these errors were encountered: