Make a copy of the set to iterate over, not the original set we will … #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 1 commit into adafruit:master from ronfischler:set-changed-during-iteration-fix

Sep 2, 2020

Contributor

ronfischler commented Sep 2, 2020

Added .copy() to the iteration of code_point over the set named "remaining." This is so we avoid iterating over the set as we removed items from it.


          Make a copy of the set to iterate over, not the original set we will …

…be removing items from

tannewt self-requested a review

September 2, 2020 23:41

Member

tannewt commented Sep 2, 2020

Thanks @ronfischler. Your change looks good. The test was broken in master and I created #29 to fix it.

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Thanks!

tannewt merged commit ca48d4a into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b17b8fd)

d96a444

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.1 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#33 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#2 from adafruit/dependency

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.3.1 from 3.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#84 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.2.2 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#29 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#28 from ronfischler/set-changed-during-iteration-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.0 from 2.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#90 from kmatch98/bitmap_mutable

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.7 from 0.11.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#38 from tannewt/run_tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#47 from tannewt/run_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet