pcf: Use bitmaptools.readinto to load font data if available
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FoamyGuy you're doing a ton of font stuff so maybe ya can review this :) ? |
|
yep, I will check it out. |
FoamyGuy
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
This is awesome! Thank you @jepler
These changes look good to me. I tested without that change in the core and confirmed current behavior is working as intended. I successfully tested this with the change in the core on a Feather rp2040 with a 2.4" Fatherwing. I saw about 4x speed increase loading yasahsi-ascii-200.pcf font.
|
Thanks so much for testing! Let's wait for the core changes before merging this though. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.7 from 3.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#128 from adafruit/anecdata-patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#126 from adafruit/anecdata-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#3 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.7 from 1.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#41 from jepler/use-bitmaptools-readinto Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#7 from brentru/fix-failing-tests > Merge pull request adafruit/Adafruit_CircuitPython_datetime#6 from cognitivegears/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.14.0 from 0.13.3: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#45 from kmatch98/master > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#46 from adafruit/tests-linting Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#18 from dastels/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.3.0 from 3.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#54 from CedarGroveStudios/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with adafruit/circuitpython#4403 this speeds up loading bitmap fonts by up to 10x (for truly large fonts, like 72pt arial bold). Smaller font loading such as 12pt Arial Bold speeds up 2x. (when loading all ASCII glyphs 32..127 inclusive)
The code will continue to work on boards that don't have the new readinto function, at the same speed as before.