Add debouncer support for B,Select and Start buttons. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on these further enhancements! Would you be willing to add a new file inside of |
|
Sure, I can add code examples ! I will add another commit tomorrow or the day after. |
|
My computer died while I originally saw this, but it looks like your use of |
tekktrik
requested changes
Feb 28, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.0 from 5.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#98 from tekktrik/dev/add-suspend-mode > Fixed readthedocs build Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.3 from 0.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#53 from sidikalamini/patch-1 > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.12 from 3.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#30 from tekktrik/doc/fix-note > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.7.0 from 2.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#34 from flom84/pygamer-start-select-buttons-debouncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have tried the buttons on my PyGamer and the UI runs quite smoothly with the de-bouncing enabled for all of them :)
This pull request is an attempt to introduce support for de-bouncing on all the PyGamer/PyBadge buttons.
I have extended the current API and kept the same function signature for the A button ( current applications that relies on this API would not be required to change if only A button is being used.)