fix for content elements that dont allow setting width and height #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesamouraipourpre
approved these changes
Jul 24, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 25, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.10.2 from 1.10.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#42 from FoamyGuy/grid_layout_label_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue noted here: adafruit/Adafruit_CircuitPython_MacroPad#10
Label and BitmapLabel do not allow setting arbitrary width and height values. So we catch the exception and just use the size that the label already is.
In the past Label and BitmapLabel had width and height class variables so those got set from GridLayout but did not actually change the visual appearance of the label. So catching this exception results in the exact behavior that we had previously.