Missing int conversions on cell_anchor_point math #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multiple places where `cell["cell_anchor_point"] * X` is used, the int conversion is missing, causing `TypeError: can't convert float to int` when an anchor_point is set to `(0.5, 0.5)` for example. ``` Traceback (most recent call last): File "code.py", line 9, in <module> File "code_pyportal.py", line 285, in switch_page File "/lib/adafruit_displayio_layout/layouts/grid_layout.py", line 413, in add_content File "/lib/adafruit_displayio_layout/layouts/grid_layout.py", line 182, in _layout_cells File "/lib/adafruit_displayio_layout/widgets/widget.py", line 297, in anchored_position File "/lib/adafruit_displayio_layout/widgets/widget.py", line 234, in _update_position TypeError: can't convert float to int ``` I didn't look into the math but I wonder, should it use `round()` rather that `int()` ? (which always rounds down)
Merged
|
I think it should always round down because we want to avoid if possible placing things outside of the display if they round up to a number higher than display size. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 17, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.3 from 8.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#147 from 300bps/main Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.15.2 from 1.15.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#67 from FoamyGuy/widget_int_fix > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#65 from Neradoc/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places where
cell["cell_anchor_point"] * Xis used, the int conversion is missing, causing an error when an anchor_point is set to(0.5, 0.5)for example. I only encountered the issue with lines 179-182, but I think the others are required too.I didn't look into the math but I wonder, should it use
round()rather thatint()? (which always rounds down)