Intial review of documentation#112
Merged
Merged
Conversation
FoamyGuy
approved these changes
Feb 3, 2021
FoamyGuy
left a comment
FoamyGuy
left a comment
Contributor
There was a problem hiding this comment.
@jposada202020 thanks for updating the docstrings and working through the actions issues!
Changes look good to me. Tested several examples on PyPortal with the updated code and no issues.
Contributor
Author
|
@FoamyGuy Thank you for the revision. And thanks for the YT streams. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 3, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#7 from rpavlik/pressure-type Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.7.0 from 1.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#58 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#59 from rsbohn/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.12.1 from 2.11.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#112 from jposada202020/updating-docs > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#110 from FoamyGuy/bitmap_label_ascent_descent Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.5 from 1.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#35 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SimpleMath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some documentation functions parameters in functions in label.py. Trying to standardize the documentation with Bitmap_label.py docs.
New documentation included for:
Label main class
_create_background_box private function
_get_ascent_descent private function
_update_background_color private function
I unfamiliar with the standard for private function classes documentation in CP. for maintainability purposes I think it will be a nice to have.