fix left edge location for first character of the label. #180
Conversation
|
The change would effect any label whose font doesn't have a value of In the screenshots shown each line is drawn by a separate label, so they each have their own bounding box. I have not done any testing around It would be possible to replicate the old behavior with the changed library, but it could be a bit tedious if the aim is to actually replicate it 100% pixel perfect. In order to do so, one would need to check the offset value in the BDF font they're using for the first character in the label and then once that value is known they could use it as an offset with either the If someone where just interested in getting close without necessarily being pixel perfect for all possible different leading characters they could just shift the x position by a little bit and eye ball it until it's lined up how they want. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.2.10 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#11 from greatest-gatsby/main > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.23.0 from 2.22.13: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#180 from FoamyGuy/fix_left_glpyh_logic Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.1.0 from 7.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#136 from vladak/user_data > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#139 from vladak/tls_port > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#141 from vladak/enable_logger_nits Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#28 from tekktrik/dev/fix-annotations > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
This fixes an issue that resulted in multiple labels using monospace fonts with different leading characters to not align properly if the shift x values from the bounding box property in the font is different for different characters.
The change hardcodes the left value to start at 0 rather than the shift x value which was actually causing the shift to get "cut out" and no included in the final bitmap, as well as causing alignment to become misaligned with other labels placed at the same x position.
This problem was original reported on the forums here: https://forums.adafruit.com/viewtopic.php?p=954011
There are details and photos in that forum post.
Here are some photos illustrating the difference with this proposed change:
Currently released version:
This PR version:
If adopted this change would result in the visual x location of labels to change slightly depending on the shift x value for the leading character in whatever font is used. Projects that used larger fonts, or fonts with larger shift x values will see a more substantial change.
This change also has the side effect of putting in the left side padding inside the background box of the label. Previously the left edge of the first character was touching the left edge of the label background rectangle, with this version the shift from the font is respected and used as a left padding.