override text property from parent on ScrollingLabel #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functionality matches Label and BitmapLabel more closely
jposada202020
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thank you! :). This work as expected. I used the script in issue #182 given by @VinceVega7. Now you are able to modify the text outside the constructor.
tested on
Adafruit CircuitPython 8.1.0-beta.0-19-gb6a761335-dirty on 2023-03-10; Adafruit PyPortal Titano with samd51j20
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 14, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.28.0 from 2.26.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#188 from FoamyGuy/scrolling_label_text_prop > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#187 from jposada202020/fixing_label_padding Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #182
As was noted on a comment in the issue
full_textwas the property that was used to change the text rather thantextlike it is with BitmapLabel and Label. So the functionality to change text after creation does exist, but the property name used to do it is not the same as it is on the other Label types.This was original done that way because I didn't know how to override parent properties while still being able to use the parent implementation of the property in some other parts of code. It turned out that we skirted around that issue by being able to call the internal
_set_text()function directly rather than using the parents properties.The change in this PR makes it so that
scrolling_lbl.textwill now function the same asscrolling_lbl.full_textwhich means it will change the text in the scrolling label as likely expected by users who try setting it.