Conversation
jepler
approved these changes
Sep 3, 2024
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
Thanks! While this should probably be fixed in the core, it doesn't hurt to make this small change especially for people on older versions of the core.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 4, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.12 from 2.2.11: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#65 from adafruit/unlock-spi-before-deinit Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
|
thanks dhalbert for the fix. 👍 i just run into this hang - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See adafruit/circuitpython#9586. As of adafruit/circuitpython#9164, on Espressif,
SPI.deinit()waits for the SPI lock to be unlocked before doing the deinit. This causesDotStar.deinit()to hang. TheDotStarobject has exclusive access to theSPIit creates and does not bother to lock and unlock it each time.So just unlock the SPI lock before doing the
deinit(). This may become unnecessary when adafruit/circuitpython#9586 is addressed, but it's safer anyway.