Skip to content

Split out spi to make guide changes easier #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

makermelissa
Copy link
Collaborator

Since we started using black, it just makes this example terrible for guides. This is my attempt to make it just a little better so people have 1 less line to comment out.

@makermelissa makermelissa requested a review from a team August 17, 2020 23:38
@ladyada ladyada merged commit be557c4 into adafruit:master Aug 18, 2020
@tannewt
Copy link
Member

tannewt commented Aug 18, 2020

Are these used in product specific guides? Why not just have one example per product? That way folks don't need to read and understand the comments.

@makermelissa
Copy link
Collaborator Author

@tannewt It's used in both a product specific guide and a general eInk breakout guide: https://learn.adafruit.com/adafruit-eink-display-breakouts/python-code

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.7.0 from 2.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#41 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#40 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.8.1 from 2.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#83 from FoamyGuy/fix_anchored_position_rounding
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#85 from kmatch98/glyph_speedup
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#79 from kmatch98/bitmap_label
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#81 from kmatch98/anchor_fix
@tannewt
Copy link
Member

tannewt commented Aug 19, 2020

Thanks for the link! I wonder if it'd be simplest to make a library that has classes for each breakout. It could encapsulate the size and the different drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants