Abstracted Status NeoPixel to make DotStar usable #14
Conversation
|
The Adafruit IO PR is adafruit/Adafruit_CircuitPython_AdafruitIO#14 and both should be merged at the same time. |
| :param int attempts: (Optional) Failed attempts before resetting the ESP32 (default=2) | ||
| :param status_neopixel: (Optional) The neopixel pin - Usually board.NEOPIXEL (default=None) | ||
| :type status_neopixel: Pin | ||
| :param status_pixel: (Optional) The pixel pin - Usually board.NEOPIXEL (default=None) |
There was a problem hiding this comment.
Why is Pin optional -- why would you pass in a pin name?
There was a problem hiding this comment.
Oh, I need to fix that.
There was a problem hiding this comment.
I'll have to wait until I get to my charger though as my laptop with my code died.
There was a problem hiding this comment.
Ok, I was able to use the online github editor to fix. The reason it is optional is because the library will function even if you don't pass it in. You just won't be able to visually tell the status.
There was a problem hiding this comment.
np with optional -- I was just confused but the Pin reference -- thanks for fixing. I like this because the user can use any neopixel/dotstar (single or string) available
|
Please note that this PR is very lightly tested as I didn't have all my hardware with me. |
|
I'll do some testing a bit later today. |
|
I've tested this with Adafruit IO CircuitPython and it works without issue on updated examples. |
|
has anyone tested it with a dotstar? |
|
I tested on an ItsyBitsy M4 without an ESP32 attached. |
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
tested dotstar function on itsy_bitsy_m4 with local time test -- worked fine! Looks good to me! Thanks
|
Merged in the Adafruit IO CircuitPython PR which referenced this PR, looks good! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.1 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#17 from brentru/update-comments-for-pixel > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#18 from brentru/expose-rssi > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#16 from brentru/expose-ip-addr > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#14 from makermelissa/master
3 participants
I abstracted Status NeoPixel to make DotStar usable. I also updated all of the examples. As this change affects the Adafruit IO library, please do the PR shortly after this PR. I will link after it's created. This is in regards to issue #13.