use struct when available, change map() to list comp #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dhalbert merged 1 commit into adafruit:master from ladyada:master

Jan 9, 2018

Member

ladyada commented Jan 9, 2018

fixes both issues - tested with metro m0 running 2.2 and m4 running 3.0


          use struct when available, change map() to list comp

a6834a9

ladyada requested a review from a team

January 9, 2018 20:40

dhalbert approved these changes

View reviewed changes

Contributor

dhalbert left a comment

Good! And comprehensions are clearer than map().

dhalbert merged commit 5c0ec65 into adafruit:master

Contributor

dhalbert commented Jan 9, 2018

Fixes #2. Fixes #3.

This was referenced Jan 9, 2018

why map instead of returning tuple? #3

Closed

fix for 3.0 compat #2

Closed

tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@a1344cd)

f17cd41

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.0 from 0.8.0:
  > use struct when available, list comp instead of map() (adafruit/Adafruit_CircuitPython_FXAS21002C#2)

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.0 from 0.8.0:
  > use struct when available, change map() to list comp (adafruit/Adafruit_CircuitPython_FXOS8700#4)

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#1 from tannewt/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.1.0 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#21 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.0.0 from 2.0.1:
  > Fix up ReadTheDocs. (adafruit/Adafruit_CircuitPython_PCA9685#9)
  > Huge refactor, switch to PWMOut compatible API. (adafruit/Adafruit_CircuitPython_PCA9685#8)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.1.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#5 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.2.0 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#8 from dhalbert/master
  > add bouncing ball example (adafruit/Adafruit_CircuitPython_SSD1306#6)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.1 from 1.0.0:
  > Changes to the tone function (adafruit/Adafruit_CircuitPython_SimpleIO#24)
  > Make lint happy
  > handle reversed range on output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet