Use SSL by default for MQTT #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Apr 8, 2021
adafruit_funhouse/network.py
Outdated
| def init_mqtt( | ||
| self, | ||
| broker, | ||
| port=MQTT.MQTT_TLS_PORT, |
There was a problem hiding this comment.
I advise using a numeric '8883' instead of the TLS_PORT const, which reads nicer and less confusing to new users (don't have to dig into MQTT lib. code if they're trying to set a port for mosquito or home assistant).
Rest looks OK!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.6 from 5.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#76 from ViennaMike/fix_fusion_modes > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.5 from 2.3.4: > Moved a function around > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#28 from jimbobbennett/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.4.0 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#42 from FoamyGuy/add_forkawesome_example > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Heart_Rate to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#13 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#5 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#7 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.3.11 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#27 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.1 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#33 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.14.2 from 1.14.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#71 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#6 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#5 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#3 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.3.0 from 4.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#63 from JPEWdev/consumer-press-release Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#71 from makermelissa/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#32 from jepler/update-simpletest Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.4.0 from 0.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#20 from adafruit/jepler-frequency-too-low > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#17 from gamblor21/mov_operators Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.9 from 1.9.8: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#76 from askpatrickw/fix-48 > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4. It looks like I was already setting it up correctly to use SSL, but just needed to use the TLS port (8883) by default.