Buffer_size improvements #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the one in `server`
|
We would appreciate comments from current users of this library -- thanks. |
FoamyGuy
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
This makes sense, and looks good to me.
Definitely is good to have response and server at least match each other in terms of buffer size. The added functionality of being able to set the buffer size and have it be used internally is nice as well for projects where someone knows they have a bigger response and enough RAM to store it.
Tested successfully on Feather ESP32-S2 TFT.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 7, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.6 from 2.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#62 from tlyu/zero-trailer > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.4.0 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#22 from FoamyGuy/py_driver_pixelbuf > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.19 from 3.3.18: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#36 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.11.0 from 3.10.19: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#110 from makermelissa/master > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.5.10 from 1.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#30 from makermelissa/master > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.13 from 1.19.12: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#80 from jposada202020/updating_examples Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.3.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#37 from matemaciek/main > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#38 from matemaciek/patch-1 > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buffer_sizeinresponse.send_fileresponseto match the one inserverbuffer_sizewhen auto-serving files.WIth current architecture I don't see an easy way to bound
response.send_file's buffer size to the one that exists inserver.