Skip to content

Fix: flags property, power valid limits getter/setter #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Fix: flags property, power valid limits getter/setter #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions adafruit_ina3221.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def __init__(
i2c (I2C): The I2C bus to which the INA3221 is connected.
address (int, optional): The I2C address of the INA3221. Defaults to DEFAULT_ADDRESS.
enable(List[int], optional): channels to initialize at start (default: all)
probe (bool, optiona): Probe for the device upon object creation, default is true
probe (bool, optional): Probe for the device upon object creation, default is true
"""
self.i2c_dev = I2CDevice(i2c, address, probe=probe)
self.reset()
Expand Down Expand Up @@ -417,7 +417,7 @@ def flags(self) -> int:
int: The current flag indicators from the Mask/Enable register,
masked for relevant flag bits.
"""
return self._read_register_bits(MASK_ENABLE, 0, 10)
return self._get_register_bits(MASK_ENABLE, 0, 10)

@property
def power_valid_limits(self) -> tuple:
Expand All @@ -427,9 +427,9 @@ def power_valid_limits(self) -> tuple:
tuple: A tuple containing the lower and upper voltage limits
in volts as (lower_limit, upper_limit).
"""
raw_value = self._device._get_register_bits(POWERVALID_LOWERLIMIT, 0, 16)
raw_value = self._get_register_bits(POWERVALID_LOWERLIMIT, 0, 16)
lower_limit = _to_signed(raw_value, 3, 16) * 8e-3
raw_value = self._device._get_register_bits(POWERVALID_UPPERLIMIT, 0, 16)
raw_value = self._get_register_bits(POWERVALID_UPPERLIMIT, 0, 16)
upper_limit = _to_signed(raw_value, 3, 16) * 8e-3
return lower_limit, upper_limit

Expand All @@ -440,8 +440,8 @@ def power_valid_limits(self, limits: tuple) -> None:
# convert to mV and twos-complement
lower_limit = _to_2comp(int(limits[0] * 1000), 3, 16)
upper_limit = _to_2comp(int(limits[1] * 1000), 3, 16)
self._device._set_register_bits(POWERVALID_LOWERLIMIT, 0, 16, lower_limit)
self._device._set_register_bits(POWERVALID_UPPERLIMIT, 0, 16, upper_limit)
self._set_register_bits(POWERVALID_LOWERLIMIT, 0, 16, lower_limit)
self._set_register_bits(POWERVALID_UPPERLIMIT, 0, 16, upper_limit)

def _get_register_bits(self, reg, offset, len):
"""return given bits from register"""
Expand Down