Skip to content

do you know about the inconsistencies? #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmorton opened this issue Oct 5, 2018 · 3 comments
Closed

do you know about the inconsistencies? #17

fmorton opened this issue Oct 5, 2018 · 3 comments

Comments

@fmorton
Copy link
Contributor

fmorton commented Oct 5, 2018

Thanks for this. It has been really helpful and I am using it on projects. I added a helper layer on top of this code for the adafruit mini remote control at:

https://github.com/fmorton/Makers_CircuitPython_remote_control

Using it, I have seen a lot of inconsistencies in results. For example, at times, if you press a button, nothing is returned. But, if you press it again, then you get it twice.

Is this something you are aware of? Is it from inconsistencies with the remote itself or do you think their are issues with the irremote code? I'm willing to dig into it, but thought I'd ask you first in case you have already pushed this as far as can be done. Particularly if there are issues with the remote itself.

Thanks!

@tannewt
Copy link
Member

tannewt commented Oct 8, 2018

IR can be pretty inconsistent on its own because its easy to have interference. We haven't worried about it much because most folks are used to having to press it a second time if it fails the first time.

My guess is that you are seeing incorrect detection of the end of a code. I bet you can improve it but that it will always be a bit finicky.

@kevinjwalters
Copy link

kevinjwalters commented Oct 19, 2018

Have a look at the description of issue in #16 to see if it's same problem.

@fmorton
Copy link
Contributor Author

fmorton commented Dec 3, 2018

The recent PR fixes this problem. Or, at least adds improvements.

@fmorton fmorton closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants