Skip to content

Allow use of root logger #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

tekktrik
Copy link
Member

Resovles #38 by fixing getLogger() so that it can be used with no provided arguments to access a singular logger (which is considered the root logger now).

I haven't tested this, though, for what it's worth.

Additionally resolves #39 since it was a quick addition.

@tekktrik tekktrik requested a review from a team September 27, 2022 23:10
@tekktrik tekktrik linked an issue Sep 29, 2022 that may be closed by this pull request
@tekktrik tekktrik requested a review from FoamyGuy October 5, 2022 00:04
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested successfully with modified simpletest on Feather ESP32-S2 TFT

@FoamyGuy FoamyGuy merged commit e5036ac into adafruit:main Oct 10, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 11, 2022
@tekktrik tekktrik deleted the dev/allow-root-logger branch January 23, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Protocol import Allow .getLogger() with no args
2 participants