Skip to content

adafruit_mma8451: prefer 'struct', falling back to 'ustruct' #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2018

Conversation

jepler
Copy link
Contributor

@jepler jepler commented May 3, 2018

As mentioned at adafruit/circuitpython#782 it will be necessary in CircuitPython 3.0 to import 'struct' instead of 'ustruct'. Use the import syntax suggested in that issue, tidying up references to ustruct; a sphinx documentation workaround becomes unneeded by doing this.

I do not actually have the mma8451 hardware, so I was unable to perform any testing.

@jepler jepler changed the title adafruit_si4713: prefer 'struct', falling back to 'ustruct' adafruit_mma8451: prefer 'struct', falling back to 'ustruct' May 3, 2018
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Lint will make sure there aren't any leftover ustructs.

@tannewt tannewt merged commit 90643d2 into adafruit:master May 3, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 7, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.1.0 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#7 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#6 from margaret/issue_5
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#19 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#18 from caternuson/iss17
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#16 from caternuson/iss7
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#15 from caternuson/iss13b
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#14 from caternuson/iss13
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#12 from caternuson/iss3
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#11 from caternuson/iss3
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#10 from elmwoodelec/master
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#6 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.3.0 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#15 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#14 from kattni/add-tx-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.2.0 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#11 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#10 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#4 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#3 from mrmcwethy/fixdocs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303 to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#5 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS0 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#5 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#3 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#7 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#3 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixKe to 1.1.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#2 from kattni/badge-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#1 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.0.3 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#7 from kattni/fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#6 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#13 from kattni/lint-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#12 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#11 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#6 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2 to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#3 from kattni/pypi
  > updated CoC
  > attack of the typo
  > Get ready to PyPI
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#2 from adafruit/deshipu-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4725 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#5 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.0 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#14 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#2 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#1 from jepler/import-struct

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#3 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#7 from kattni/pypi
  > updated CoC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants