-
Notifications
You must be signed in to change notification settings - Fork 24
Added deep and light sleep functions #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later, it will also be possible to wake up on button pushes (or pin changes). So you might think about how this will fit into the proposed API. The time arguments could become optional, and there would also be optional button or pin arguments. You may want to make the time arguments require a keyword in that case.
Thanks Dan. We can make the time parameter optional once we have the button press wake feature added. I think it will work as it is for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience. This is OK by me now. @tannewt any further comments?
Just for completeness, here's the test script I used to test neopixels for light sleep:
For deep sleep, I basically used a slightly modified version of Dan's script at adafruit/circuitpython#3767 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Thanks!
Excellent :) |
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.0 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#13 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.10.0 from 2.9.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#99 from FoamyGuy/wrapping Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#31 from makermelissa/deepsleep
Fixes #20. This adds the deep and light sleep functions.