Support chunked transfers in wget - #118
Merged
Merged
Conversation
FoamyGuy
reviewed
Dec 9, 2025
# Conflicts: # adafruit_portalbase/__init__.py
FoamyGuy
approved these changes
Jan 14, 2026
FoamyGuy
left a comment
Contributor
There was a problem hiding this comment.
I merged main to this branch and it resolves the outlined label conflict maintaining compatibility.
These changes look good to me. I tested with a Fruit Jam and a local Flask server that has both streaming and non-streaming response endpoints and both seem to work as expected.
Contributor
Author
|
@FoamyGuy Thank you for putting in the effort to test these changes properly. 💯 |
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 15, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.4.7 from 2.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_PN532#70 from gdudek/fix/long-ats-buffer Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 3.1.27 from 3.1.26: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#32 from LoganCarter08/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.5.0 from 3.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#118 from relic-se/chunked-transfer-encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunked transfers are already supported within
adafruit_requestsbut thecontent-lengthcheck withinadafruit_portalbase.network.NetworkBase.wget(see below) prevents them from working because they leave that header omitted. (see https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Transfer-Encoding#chunked for reference)Adafruit_CircuitPython_PortalBase/adafruit_portalbase/network.py
Lines 336 to 339 in 25fc43d
This update extends
wgetto allow chunked transfers.I've provided a simple demonstration using the Adafruit Fruit Jam to download the source files zipball from a GitHub repository which uses chunked transfer encoding.
I've provided more information in my investigation here: relic-se/Fruit_Jam_Library#12.
This update also includes compatibility fixes for
adafruit_display_textversion 3.4.0 related to outlined labels. (https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/releases/tag/3.4.0)