Skip to content

Remove dependency to simpleio #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2023
Merged

Remove dependency to simpleio #22

merged 2 commits into from
Mar 19, 2023

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Mar 18, 2023

Less code, fewer imports, fewer libraries to install.

BiffoBear
BiffoBear reviewed Mar 19, 2023
View reviewed changes
jposada202020
jposada202020 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @Neradoc and thank you @BiffoBear for reviewing.

@jposada202020 jposada202020 merged commit 1da2278 into adafruit:main Mar 19, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 20, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2415fa6)
8c8d691 
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.15 from 1.1.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGBLED#22 from Neradoc/remove-simpleio
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiffoBear BiffoBear BiffoBear left review comments

@jposada202020 jposada202020 jposada202020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neradoc @BiffoBear @jposada202020