Use a 512 bytes buffer for the fill operations #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
Nov 3, 2017
adafruit_rgb_display/rgb.py
Outdated
| @@ -80,7 +80,7 @@ def fill_rectangle(self, x, y, width, height, color): | |||
| w = min(self.width - x, max(1, width)) | |||
| h = min(self.height - y, max(1, height)) | |||
| self._block(x, y, x + w - 1, y + h - 1, b'') | |||
| chunks, rest = divmod(w * h, 512) | |||
| chunks, rest = divmod(w * h, 256) | |||
There was a problem hiding this comment.
Could you add a comment explaining the buffer choice size?
There was a problem hiding this comment.
I moved it into a constant and added explanation.
dhalbert
reviewed
Nov 3, 2017
adafruit_rgb_display/rgb.py
Outdated
| @@ -80,7 +80,7 @@ def fill_rectangle(self, x, y, width, height, color): | |||
| w = min(self.width - x, max(1, width)) | |||
| h = min(self.height - y, max(1, height)) | |||
| self._block(x, y, x + w - 1, y + h - 1, b'') | |||
| chunks, rest = divmod(w * h, 512) | |||
| chunks, rest = divmod(w * h, 256) | |||
| pixel = self._encode_pixel(color) | |||
| if chunks: | |||
| data = pixel * 512 | |||
There was a problem hiding this comment.
Indeed, I should slow down a little.
Right now we are using 1024 bytes (512 16-bit pixels), and it doesn't really give us any speed advantage, since the DMA buffer is only 512 bytes anyways.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 4, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.0.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#10 from mrmcwethy/lint > Update to SSD1331 driver (adafruit/Adafruit_CircuitPython_RGB_Display#11) > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#9 from deshipu/fix-small-buffer > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#8 from deshipu/fix-readinto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are using 1024 bytes (512 16-bit pixels), and it doesn't
really give us any speed advantage, since the DMA buffer is only 512
bytes anyways.