Better handle errors by retrying #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

makermelissa merged 3 commits into adafruit:master from tannewt:better_error_handling

Nov 6, 2020

Member

tannewt commented Nov 6, 2020

Handle send failures
Handle send exception from ESP32SPI
Handle failed response read
Handle connect() failures
Handle runtime error from ESP32SPI on connect

tannewt added 3 commits

November 4, 2020 18:17


          Better handle errors by retrying

e0f6d5e

* Handle send failures
* Handle send exception from ESP32SPI
* Handle failed response read
* Handle connect() failures
* Handle runtime error from ESP32SPI on connect


          Black

019d105


          Add unit tests

7f2877e

tannewt requested a review from makermelissa

November 6, 2020 18:17

makermelissa approved these changes

View reviewed changes

Collaborator

makermelissa left a comment

Code looks good to me. Tested with PyPortal CMA example and this appears to have fixed the issue.

makermelissa merged commit 333b586 into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f165e24)

14c89d1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.2 from 5.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#60 from adafruit/fix-super-call

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.3 from 3.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#114 from tannewt/esp32spi_fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.5 from 5.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#63 from adafruit/ladyada-patch-3

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.2 from 3.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#93 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.3 from 2.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#96 from FoamyGuy/add_matrixportal_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.0 from 1.8.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#38 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.5 from 0.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#23 from adafruit/nina-fw-1.7.1-updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.5 from 1.7.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#50 from tannewt/better_error_handling
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#49 from adafruit/no-https-wifitest
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#45 from tannewt/fix_close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet