Skip to content

Make sure we turn ambient pressure to an int. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caternuson merged 2 commits into from
Jan 29, 2021
Merged

Make sure we turn ambient pressure to an int. #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbaca15
Make sure we turn ambient pressure to an int.
rpavlik Jan 24, 2021
1859eee
Also convert the supplied altitude to int
rpavlik Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adafruit_scd30.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ def ambient_pressure(self):

@ambient_pressure.setter
def ambient_pressure(self, pressure_mbar):
pressure_mbar = int(pressure_mbar)
if pressure_mbar != 0 and (pressure_mbar > 1200 or pressure_mbar < 700):
raise AttributeError("ambient_pressure must be from 700 to 1200 mBar")
self._send_command(_CMD_CONTINUOUS_MEASUREMENT, pressure_mbar)
Expand All @@ -138,7 +139,7 @@ def altitude(self):

@altitude.setter
def altitude(self, altitude):
self._send_command(_CMD_SET_ALTITUDE_COMPENSATION, altitude)
self._send_command(_CMD_SET_ALTITUDE_COMPENSATION, int(altitude))

@property
def temperature_offset(self):
Expand Down