adafruit_sdcard.py : group related cmds in a single transaction #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most cards tested wants to have CS low during a group of read-multiple / write-multiple commands. Also, some can insert 0x7F return bytes after CMD12 (response type R1b) These changes make reading and writing big chunks of data at once possible, on all cards tested, where previously all but the oldest one would fail when reading/writng more than a block.
dhalbert
approved these changes
Oct 28, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 18, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.2.5 from 3.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_SD#29 from dhalbert/avoid-longint > Merge pull request adafruit/Adafruit_CircuitPython_SD#26 from Anton-2/master > Merge pull request adafruit/Adafruit_CircuitPython_SD#24 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_SD#23 from Anton-2/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most cards tested wants to have CS low during a group of read-multiple / write-multiple commands.
Also, some can insert 0x7F return bytes after CMD12 (response type R1b)
These changes make reading and writing big chunks of data at once possible, on all cards tested, where previously all but the oldest one would fail when reading/writng more than a block.