Improve the error message when it fails to read the version in SPI mode #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ladyada merged 1 commit into adafruit:master from makermelissa:master

Apr 21, 2021

Collaborator

makermelissa commented Apr 21, 2021

Fixes #18.


          Improve the error message when it fails to read the version in SPI mode

69fa183

makermelissa requested a review from a team

April 21, 2021 18:28

jerryneedell approved these changes

View reviewed changes

Contributor

jerryneedell left a comment

Did not test, but the change looks good to me.

ladyada approved these changes

View reviewed changes

ladyada merged commit c370e5b into adafruit:master

Contributor

jerryneedell commented Apr 21, 2021

Even tested it!! works fine -- I generate the error a lot!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@41b2432)

33d5bf2

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.1.0 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#44 from sandyjmacdonald/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#19 from makermelissa/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.0.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#10 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#9 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.0.0 from 1.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#60 from makermelissa/main
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#58 from FoamyGuy/pylintrc_ignore_import
  > Removed pylint process from github workflow

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.6.0 from 1.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#33 from makermelissa/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet